RGBCube/dix
1
Fork 0
mirror of https://github.com/RGBCube/dix synced 2025-07-28 12:17:45 +00:00
Code Issues Activity

store: add comments to explain why Path::canonicalize is needed

Browse source
This commit is contained in:
Dragyx 2025-05-06 16:42:24 +02:00
parent 63de1f090a
commit 03f009d297
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/store.rs
View file

@ -60,6 +60,7 @@ SELECT p, c from graph;
/// ///
/// in the future, we might wan't to switch to async /// in the future, we might wan't to switch to async
pub fn get_packages(path: &std::path::Path) -> Result<Vec<(i64, String)>> { pub fn get_packages(path: &std::path::Path) -> Result<Vec<(i64, String)>> {
// resolve symlinks and convert to a string
let p: String = path.canonicalize()?.to_string_lossy().into_owned(); let p: String = path.canonicalize()?.to_string_lossy().into_owned();
let conn = Connection::open(DATABASE_URL)?; let conn = Connection::open(DATABASE_URL)?;
@ -77,6 +78,7 @@ pub fn get_packages(path: &std::path::Path) -> Result<Vec<(i64, String)>> {
/// ///
/// in the future, we might wan't to switch to async /// in the future, we might wan't to switch to async
pub fn get_closure_size(path: &std::path::Path) -> Result<i64> { pub fn get_closure_size(path: &std::path::Path) -> Result<i64> {
// resolve symlinks and convert to a string
let p: String = path.canonicalize()?.to_string_lossy().into_owned(); let p: String = path.canonicalize()?.to_string_lossy().into_owned();
let conn = Connection::open(DATABASE_URL)?; let conn = Connection::open(DATABASE_URL)?;
@ -95,6 +97,7 @@ pub fn get_closure_size(path: &std::path::Path) -> Result<i64> {
/// ///
/// The mapping from id to graph can be obtained by using [``get_packages``] /// The mapping from id to graph can be obtained by using [``get_packages``]
pub fn get_dependency_graph(path: &std::path::Path) -> Result<HashMap<i64, Vec<i64>>> { pub fn get_dependency_graph(path: &std::path::Path) -> Result<HashMap<i64, Vec<i64>>> {
// resolve symlinks and convert to a string
let p: String = path.canonicalize()?.to_string_lossy().into_owned(); let p: String = path.canonicalize()?.to_string_lossy().into_owned();
let conn = Connection::open(DATABASE_URL)?; let conn = Connection::open(DATABASE_URL)?;