From 156a0110c724ce3a98327190e8a667657e4ed3c1 Mon Sep 17 00:00:00 2001
From: gin-lsl <gin_lsl@outlook.com>
Date: Wed, 25 Jun 2025 06:09:03 +0800
Subject: [PATCH] fix(npm): update incompatible npm scripts (#1137)

I use Nushell and npm, and noticed that the npm section hasn't been
updated for a long time, to the point where it no longer works with
current npm versions. In fact, the current script produces the following
result:

![image](https://github.com/user-attachments/assets/272a6a37-c623-452a-94ab-2f3c0ee54beb)

So I've updated the npm-related scripts to fix this issue. Now it works
correctly:

![image](https://github.com/user-attachments/assets/fcf8b590-0ede-4571-bd52-611cf4c9fdd3)


Additionally, since npm -l | lines generates over 900 lines of output,
this causes each run to take a long time (at least on my machine).
Therefore, I've implemented caching using stor to store the results,
which significantly reduces the execution time for subsequent calls.
With caching enabled, the delay is now barely noticeable.
---
 custom-completions/npm/npm-completions.nu | 30 ++++++++++++++++-------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/custom-completions/npm/npm-completions.nu b/custom-completions/npm/npm-completions.nu
index 0195b18..41d61cf 100644
--- a/custom-completions/npm/npm-completions.nu
+++ b/custom-completions/npm/npm-completions.nu
@@ -1,11 +1,22 @@
 def "nu-complete npm" [] {
-  ^npm -l
-  |lines
-  |find 'Run "'
-  |str trim
-  |split column -c ' '
-  |get column4
-  |str replace '"' ''
+  let db = stor open
+
+  try {
+    # query commanders from in-mem db
+    $db | query db "SELECT * FROM npm_commanders_table"
+  } catch {
+    # if catched error, create table and insert all data
+    stor create --table-name npm_commanders_table --columns { value: str, description: str }
+
+    let npm_commanders = ^npm -l
+      | lines
+      | where $it =~ '\s{4}[a-z\-]+.*\s{4,}'
+      | parse -r '\s*(?P<value>[^ ]+)\s*(?P<description>\w.*)'
+
+    $npm_commanders | stor insert --table-name npm_commanders_table
+
+    $npm_commanders
+  }
 }
 
 export extern "npm" [
@@ -14,8 +25,9 @@ export extern "npm" [
 
 def "nu-complete npm run" [] {
   open ./package.json
-  |get scripts
-  |columns
+  | get scripts
+  | transpose
+  | rename value description
 }
 
 export extern "npm run" [