From 001322737700b19e0ce17c6d1c3941ef02f7dace Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Mon, 31 Jan 2022 08:28:50 -0500 Subject: [PATCH] LibCrypto: Change UnsignedBigInteger parser to use a StringView SignedBigInteger already accepts a StringView; let's avoid the heap allocation in UnsignedBigInteger. --- Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.cpp | 2 +- Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.cpp b/Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.cpp index 51e1d0ee56..ef56015395 100644 --- a/Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.cpp +++ b/Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.cpp @@ -67,7 +67,7 @@ size_t UnsignedBigInteger::export_data(Bytes data, bool remove_leading_zeros) co return out; } -UnsignedBigInteger UnsignedBigInteger::from_base(u16 N, const String& str) +UnsignedBigInteger UnsignedBigInteger::from_base(u16 N, StringView str) { VERIFY(N <= 36); UnsignedBigInteger result; diff --git a/Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h b/Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h index 4146aa736b..14c9a90b4c 100644 --- a/Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h +++ b/Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h @@ -53,7 +53,7 @@ public: size_t export_data(Bytes, bool remove_leading_zeros = false) const; - static UnsignedBigInteger from_base(u16 N, const String& str); + static UnsignedBigInteger from_base(u16 N, StringView str); String to_base(u16 N) const; u64 to_u64() const;