From 005cd4e4569b28816f911d292803029e0a995d74 Mon Sep 17 00:00:00 2001
From: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
Date: Mon, 12 Sep 2022 23:11:54 +0200
Subject: [PATCH] Meta: Remove unused and outdated lint-missing-resources.sh
 lint

This was apparently never used by anyone except me, and currently
fails silently.

The script originally allowed easy inspection of potentially missing
resources, but that seems no longer useful. Even after restoring the
script to a working state, I found nothing with it.

A somewhat usable version might be available at
https://github.com/BenWiederhake/serenity/tree/historic/lint-missing-resources.sh

However, there seems to be no interest in the script, so it is better to
remove it.
---
 Meta/lint-ci.sh                |  7 +++----
 Meta/lint-missing-resources.sh | 19 -------------------
 2 files changed, 3 insertions(+), 23 deletions(-)
 delete mode 100755 Meta/lint-missing-resources.sh

diff --git a/Meta/lint-ci.sh b/Meta/lint-ci.sh
index 14db5da60a..7ecf89986c 100755
--- a/Meta/lint-ci.sh
+++ b/Meta/lint-ci.sh
@@ -28,11 +28,11 @@ for cmd in \
         Meta/check-png-sizes.sh \
         Meta/check-style.py \
         Meta/lint-executable-resources.sh \
-        Meta/lint-keymaps.py \
-        Meta/lint-shell-scripts.sh \
         Meta/lint-gml-format.sh \
+        Meta/lint-keymaps.py \
         Meta/lint-prettier.sh \
-        Meta/lint-python.sh; do
+        Meta/lint-python.sh \
+        Meta/lint-shell-scripts.sh; do
     echo "Running ${cmd}... "
     if "${cmd}" "$@"; then
         echo -e "[${GREEN}OK${NC}]: ${cmd}"
@@ -76,7 +76,6 @@ if [ "$ports" = true ]; then
     fi
 fi
 
-echo "(Not running lint-missing-resources.sh due to high false-positive rate.)"
 echo "(Also look out for check-symbols.sh, which can only be executed after the build!)"
 
 exit "${FAILURES}"
diff --git a/Meta/lint-missing-resources.sh b/Meta/lint-missing-resources.sh
deleted file mode 100755
index bb21b5c4af..0000000000
--- a/Meta/lint-missing-resources.sh
+++ /dev/null
@@ -1,19 +0,0 @@
-#!/usr/bin/env bash
-
-set -eo pipefail
-
-script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
-cd "$script_path/.."
-
-# The dollar symbol in sed's argument is for "end of line", not any shell variable.
-# shellcheck disable=SC2016
-grep -Eirh '(?<!file://)(?<!\.)(?<!})(?<!\()/(etc|res|usr|www)/' AK/ Base DevTools/ Documentation/ Kernel/ Services/ Userland/ | \
-sed -re 's,^.*["= `]/([^"%`: ]+[^"%`: /.])/?(["%`: .].*)?$,\1,' | \
-sort -u | \
-while read -r referenced_resource
-do
-    if ! [ -r "Base/${referenced_resource}" ] && ! [ -r "Build/Root/${referenced_resource}" ]
-    then
-        echo "Potentially missing resource: ${referenced_resource}"
-    fi
-done