RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-22 17:15:08 +00:00
Code Issues Activity Actions

LibHTML: Implement the "margin" shorthand property

Browse source 
This is a very bulky way of doing this, and doesn't seem sustainable to
implement every shorthand property this way, but it's a place to start.

The "margin" CSS property now expands into its four longhands as far as
my understanding of the specs.

Note that shorthand expansion happens when we *resolve* style, not when
we parse CSS. I'm not sure this is correct anymore, I think other UA's
may actually expand shorthands into the declaration directly at parse
these days. If so, we should do this at parsing as well.
This commit is contained in:
Andreas Kling 2019-11-18 11:49:19 +01:00
parent e6e41e4fb8
commit 00d171e4d6
4 changed files with 82 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibHTML/CSS/Length.h
View file

@ -25,8 +25,8 @@ public:
String to_string() const
{
if (is_auto())
return "auto";
return String::format("%d [Length/Absolute]", m_value);
return "[Length/auto]";
return String::format("%d [Length/px]", m_value);
}
int to_px() const