RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:28:12 +00:00
Code Issues Activity Actions

WebDriver: Do not throw an error when closing an inactive session

Browse source 
The spec states to only try to close the session *if* it exists. This
situation can occur when closing a session after a Close Window command,
as the session will be closed automatically if it was the last window.
This commit is contained in:
Timothy Flynn 2023-03-07 10:50:20 -05:00 • committed by Linus Groh
parent 12015a4db6
commit 010be9b7c2
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/WebDriver/Client.cpp
View file

@ -184,8 +184,8 @@ Web::WebDriver::Response Client::delete_session(Web::WebDriver::Parameters param
dbgln_if(WEBDRIVER_DEBUG, "Handling DELETE /session/<session_id>");
// 1. If the current session is an active session, try to close the session.
auto session = TRY(find_session_with_id(parameters[0]));
TRY(session->stop());
if (auto session = find_session_with_id(parameters[0]); !session.is_error())
TRY(session.value()->stop());
// 2. Return success with data null.
return JsonValue {};