RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 18:05:07 +00:00
Code Issues Activity Actions

Kernel: Set correct KeyCode count

Browse source 
The underlying value of the `KeyCode::Key_*` enum values starts at 0,
so we should add 1 to `Key_Menu` to get the correct count.
This commit is contained in:
Jelle Raaijmakers 2024-01-14 18:23:33 +01:00 • committed by Andrew Kaster
parent b7bce816b2
commit 015622bc22
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/KeyCode.h
View file

@ -152,7 +152,7 @@ enum KeyCode : u8 {
Key_Shift Key_Shift
= Key_LeftShift, = Key_LeftShift,
}; };
int const key_code_count = Key_Menu; size_t const key_code_count = Key_Menu + 1;
enum KeyModifier { enum KeyModifier {
Mod_None = 0x00, Mod_None = 0x00,

4
Userland/Applications/Piano/MainWidget.cpp
View file

@ -189,7 +189,7 @@ void MainWidget::turn_off_pressed_keys()
{ {
if (m_keys_widget->mouse_note() != -1) if (m_keys_widget->mouse_note() != -1)
m_track_manager.keyboard()->set_keyboard_note_in_active_octave(m_keys_widget->mouse_note(), DSP::Keyboard::Switch::Off); m_track_manager.keyboard()->set_keyboard_note_in_active_octave(m_keys_widget->mouse_note(), DSP::Keyboard::Switch::Off);
for (int i = 0; i < key_code_count; ++i) { for (size_t i = 0u; i < key_code_count; ++i) {
if (m_keys_pressed[i]) if (m_keys_pressed[i])
note_key_action(i, DSP::Keyboard::Switch::Off); note_key_action(i, DSP::Keyboard::Switch::Off);
} }
@ -199,7 +199,7 @@ void MainWidget::turn_on_pressed_keys()
{ {
if (m_keys_widget->mouse_note() != -1) if (m_keys_widget->mouse_note() != -1)
m_track_manager.keyboard()->set_keyboard_note_in_active_octave(m_keys_widget->mouse_note(), DSP::Keyboard::Switch::On); m_track_manager.keyboard()->set_keyboard_note_in_active_octave(m_keys_widget->mouse_note(), DSP::Keyboard::Switch::On);
for (int i = 0; i < key_code_count; ++i) { for (size_t i = 0u; i < key_code_count; ++i) {
if (m_keys_pressed[i]) if (m_keys_pressed[i])
note_key_action(i, DSP::Keyboard::Switch::On); note_key_action(i, DSP::Keyboard::Switch::On);
} }