RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Set children of button layout box to be non-inline

Browse source 
When modifying the button layout during tree building to use flex for
vertical alignment, let's explicitly set the button box's children to
be non-inline. It doesn't make sense to layout the button as an IFC
when its only child is a flex container.
This commit is contained in:
Aliaksandr Kalenik 2023-09-10 22:14:25 +02:00 • committed by Andreas Kling
parent 38d9c4d19c
commit 0160d921e9
6 changed files with 28 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Tests/LibWeb/Layout/expected/block-and-inline/button-baseline-align.txt
View file

@ -1,24 +1,22 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x47.671875 children: inline
line 0 width: 61.1875, height: 47.671875, bottom: 47.671875, baseline: 35.84375
frag 0 from BlockContainer start: 0, length: 0, rect: [8,8 61.1875x47.671875]
BlockContainer <div.ib> at (8,8) content-size 61.1875x47.671875 inline-block [BFC] children: inline
line 0 width: 61.1875, height: 47.671875, bottom: 47.671875, baseline: 35.84375
frag 0 from BlockContainer start: 0, length: 0, rect: [9,26 17.828125x21.84375]
frag 1 from TextNode start: 0, length: 1, rect: [28,30 8x17.46875]
BlockContainer <body> at (8,8) content-size 784x47.6875 children: inline
line 0 width: 61.1875, height: 47.6875, bottom: 47.6875, baseline: 33.84375
frag 0 from BlockContainer start: 0, length: 0, rect: [8,8 61.1875x47.6875]
BlockContainer <div.ib> at (8,8) content-size 61.1875x47.6875 inline-block [BFC] children: inline
line 0 width: 61.1875, height: 47.6875, bottom: 47.6875, baseline: 33.84375
frag 0 from BlockContainer start: 0, length: 0, rect: [9,24 17.828125x21.84375]
frag 1 from TextNode start: 0, length: 1, rect: [28,28 8x17.46875]
" "
frag 2 from BlockContainer start: 0, length: 0, rect: [41,10 23.359375x43.671875]
frag 2 from BlockContainer start: 0, length: 0, rect: [41,10 23.359375x43.6875]
TextNode <#text>
BlockContainer <div.label> at (9,26) content-size 17.828125x21.84375 inline-block [BFC] children: inline
BlockContainer <div.label> at (9,24) content-size 17.828125x21.84375 inline-block [BFC] children: inline
line 0 width: 17.828125, height: 21.84375, bottom: 21.84375, baseline: 16.921875
frag 0 from TextNode start: 0, length: 1, rect: [9,26 17.828125x21.84375]
frag 0 from TextNode start: 0, length: 1, rect: [9,24 17.828125x21.84375]
"A"
TextNode <#text>
TextNode <#text>
BlockContainer <button> at (41,10) content-size 23.359375x43.671875 inline-block [BFC] children: inline
line 0 width: 23.359375, height: 43.671875, bottom: 43.671875, baseline: 33.84375
frag 0 from BlockContainer start: 0, length: 0, rect: [41,10 23.359375x43.6875]
BlockContainer <button> at (41,10) content-size 23.359375x43.6875 inline-block [BFC] children: not-inline
BlockContainer <(anonymous)> at (41,10) content-size 23.359375x43.6875 flex-container(column) [FFC] children: not-inline
BlockContainer <(anonymous)> at (41,10) content-size 23.359375x43.6875 flex-item [BFC] children: inline
line 0 width: 23.359375, height: 43.6875, bottom: 43.6875, baseline: 33.84375
@ -29,12 +27,12 @@ Viewport <#document> at (0,0) content-size 800x600 children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x47.671875]
PaintableWithLines (BlockContainer<DIV>.ib) [8,8 61.1875x47.671875]
PaintableWithLines (BlockContainer<DIV>.label) [8,25 19.828125x23.84375]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x47.6875]
PaintableWithLines (BlockContainer<DIV>.ib) [8,8 61.1875x47.6875]
PaintableWithLines (BlockContainer<DIV>.label) [8,23 19.828125x23.84375]
TextPaintable (TextNode<#text>)
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<BUTTON>) [36,8 33.359375x47.671875]
PaintableWithLines (BlockContainer<BUTTON>) [36,8 33.359375x47.6875]
PaintableWithLines (BlockContainer(anonymous)) [41,10 23.359375x43.6875]
PaintableWithLines (BlockContainer(anonymous)) [41,10 23.359375x43.6875]
TextPaintable (TextNode<#text>)