RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:07:44 +00:00
Code Issues Activity Actions

LibWeb: Remove now-unused PaintableBox::for_each_child_in_paint_order()

Browse source
This commit is contained in:
Andreas Kling 2022-03-21 14:57:00 +01:00
parent a779ace6a1
commit 01662b2320
2 changed files with 0 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

66
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -462,72 +462,6 @@ void PaintableBox::set_stacking_context(NonnullOwnPtr<StackingContext> stacking_
m_stacking_context = move(stacking_context); m_stacking_context = move(stacking_context);
} }
template<typename Callback>
void PaintableBox::for_each_child_in_paint_order(Callback callback) const
{
// Element traversal using the order defined in https://www.w3.org/TR/CSS2/zindex.html#painting-order.
// Note: Some steps are skipped because they are not relevant to node traversal.
// 3. Stacking contexts formed by positioned descendants with negative z-indices (excluding 0) in z-index order
// (most negative first) then tree order.
// FIXME: This does not retrieve elements in the z-index order.
layout_box().for_each_child([&](auto& child) {
if (!child.is_positioned() || !is<Layout::Box>(child))
return;
auto& box_child = verify_cast<Layout::Box>(child);
auto* stacking_context = box_child.paint_box()->stacking_context();
if (stacking_context && box_child.computed_values().z_index().has_value() && box_child.computed_values().z_index().value() < 0)
callback(child);
});
// 4. For all its in-flow, non-positioned, block-level descendants in tree order: If the element is a block, list-item,
// or other block equivalent:
layout_box().for_each_child([&](auto& child) {
if (is<Layout::Box>(child) && verify_cast<Layout::Box>(child).paint_box()->stacking_context())
return;
if (!child.is_positioned())
callback(child);
});
// 5. All non-positioned floating descendants, in tree order. For each one of these, treat the element as if it created
// a new stacking context, but any positioned descendants and descendants which actually create a new stacking context
// should be considered part of the parent stacking context, not this new one.
layout_box().for_each_child([&](auto& child) {
if (is<Layout::Box>(child) && verify_cast<Layout::Box>(child).paint_box()->stacking_context())
return;
if (child.is_positioned())
callback(child);
});
// 8. All positioned descendants with 'z-index: auto' or 'z-index: 0', in tree order. For those with 'z-index: auto', treat
// the element as if it created a new stacking context, but any positioned descendants and descendants which actually
// create a new stacking context should be considered part of the parent stacking context, not this new one. For those
// with 'z-index: 0', treat the stacking context generated atomically.
layout_box().for_each_child([&](auto& child) {
if (!child.is_positioned() || !is<Layout::Box>(child))
return;
auto& box_child = verify_cast<Layout::Box>(child);
auto* stacking_context = box_child.paint_box()->stacking_context();
if (stacking_context && box_child.computed_values().z_index().has_value() && box_child.computed_values().z_index().value() == 0)
callback(child);
});
// 9. Stacking contexts formed by positioned descendants with z-indices greater than or equal to 1 in z-index order
// (smallest first) then tree order.
// FIXME: This does not retrieve elements in the z-index order.
layout_box().for_each_child([&](auto& child) {
if (!child.is_positioned() || !is<Layout::Box>(child))
return;
auto& box_child = verify_cast<Layout::Box>(child);
auto* stacking_context = box_child.paint_box()->stacking_context();
if (stacking_context && box_child.computed_values().z_index().has_value() && box_child.computed_values().z_index().value() > 0)
callback(child);
});
}
Optional<HitTestResult> PaintableBox::hit_test(Gfx::FloatPoint const& position, HitTestType type) const Optional<HitTestResult> PaintableBox::hit_test(Gfx::FloatPoint const& position, HitTestType type) const
{ {
if (layout_box().is_initial_containing_block_box()) { if (layout_box().is_initial_containing_block_box()) {

3
Userland/Libraries/LibWeb/Painting/PaintableBox.h
View file

@ -127,9 +127,6 @@ protected:
virtual void paint_box_shadow(PaintContext&) const; virtual void paint_box_shadow(PaintContext&) const;
private: private:
template<typename Callback>
void for_each_child_in_paint_order(Callback) const;
Painting::BorderRadiusData normalized_border_radius_data() const; Painting::BorderRadiusData normalized_border_radius_data() const;
OwnPtr<Painting::StackingContext> m_stacking_context; OwnPtr<Painting::StackingContext> m_stacking_context;