RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 14:25:08 +00:00
Code Issues Activity Actions

LibWeb: Make sure nodes are adopted when moving between documents

Browse source 
Otherwise, the "referencing node count" accounting won't be accurate,
and anything that accesses the document will be confused.
This commit is contained in:
Andreas Kling 2020-10-22 23:37:17 +02:00
parent c67b45aa1f
commit 018b458962
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/DOM/Node.cpp
View file

@ -170,6 +170,8 @@ const Element* Node::parent_element() const
RefPtr<Node> Node::append_child(NonnullRefPtr<Node> node, bool notify)
{
if (&node->document() != &document())
document().adopt_node(node);
TreeNode<Node>::append_child(node, notify);
return node;
}
@ -182,6 +184,8 @@ RefPtr<Node> Node::insert_before(NonnullRefPtr<Node> node, RefPtr<Node> child, b
dbg() << "FIXME: Trying to insert_before() a bogus child";
return nullptr;
}
if (&node->document() != &document())
document().adopt_node(node);
TreeNode<Node>::insert_before(node, child, notify);
return node;
}
@ -195,6 +199,10 @@ void Node::remove_all_children()
void Node::set_document(Badge<Document>, Document& document)
{
if (m_document == &document)
return;
document.ref_from_node({});
m_document->unref_from_node({});
m_document = &document;
}