RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:38:10 +00:00
Code Issues Activity Actions

Kernel: Don't log profile data before/after the process/thread lifetime

Browse source 
There were a few cases where we could end up logging profiling events
before or after the associated process or thread exists in the profile:

After enabling profiling we might end up with CPU samples before we
had a chance to synthesize process/thread creation events.

After a thread exits we would still log associated kmalloc/kfree
events. Instead we now just ignore those events.
This commit is contained in:
Gunnar Beutner 2021-05-30 16:24:53 +02:00 • committed by Andreas Kling
parent d24dd7a3df
commit 01c75e3a34
8 changed files with 39 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Kernel/Heap/kmalloc.cpp
View file

@ -257,11 +257,11 @@ void* kmalloc(size_t size)
PANIC("kmalloc: Out of memory (requested size: {})", size);
}
Process* current_process = Process::current();
if (!current_process && Scheduler::colonel_initialized())
current_process = Scheduler::colonel();
if (current_process)
PerformanceManager::add_kmalloc_perf_event(*current_process, size, (FlatPtr)ptr);
Thread* current_thread = Thread::current();
if (!current_thread)
current_thread = Processor::idle_thread();
if (current_thread)
PerformanceManager::add_kmalloc_perf_event(*current_thread, size, (FlatPtr)ptr);
return ptr;
}
@ -277,11 +277,11 @@ void kfree(void* ptr)
++g_nested_kfree_calls;
if (g_nested_kfree_calls == 1) {
Process* current_process = Process::current();
if (!current_process && Scheduler::colonel_initialized())
current_process = Scheduler::colonel();
if (current_process)
PerformanceManager::add_kfree_perf_event(*current_process, 0, (FlatPtr)ptr);
Thread* current_thread = Thread::current();
if (!current_thread)
current_thread = Processor::idle_thread();
if (current_thread)
PerformanceManager::add_kfree_perf_event(*current_thread, 0, (FlatPtr)ptr);
}
g_kmalloc_global->m_heap.deallocate(ptr);