RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:18:11 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Log JavaScript exceptions raised by web content

Browse source 
Instead of hiding JS exceptions raised on the web, we now print them to
the debug log. This will make it a bit easier to work out why some web
pages aren't working right. :^)
This commit is contained in:
Andreas Kling 2020-11-29 16:48:14 +01:00
parent 2dd03a4200
commit 01c8765519
3 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibJS/Runtime/VM.cpp
View file

@ -264,8 +264,7 @@ Value VM::construct(Function& function, Function& new_target, Optional<MarkedVal
void VM::throw_exception(Exception* exception)
{
#ifdef VM_DEBUG
if (exception->value().is_object() && exception->value().as_object().is_error()) {
if (should_log_exceptions() && exception->value().is_object() && exception->value().as_object().is_error()) {
auto& error = static_cast<Error&>(exception->value().as_object());
dbgln("Throwing JavaScript Error: {}, {}", error.name(), error.message());
@ -276,7 +275,7 @@ void VM::throw_exception(Exception* exception)
dbgln(" {}", function_name);
}
}
#endif
m_exception = exception;
unwind(ScopeType::Try);
}