RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 09:04:59 +00:00
Code Issues Activity Actions

LibGUI: Do not paint scrollbar button highlight for scrollbars without scrubber

Browse source 
If a scrollbar doesn't have a scrubber (because the view it scrolls is
large enough to display all its contents without scrolling), then
it ignores all clicks. We shouldn't draw a hover highlight that suggests
clickability in that case.
This commit is contained in:
Nico Weber 2020-09-09 14:57:12 -04:00 • committed by Andreas Kling
parent 34d210ecf5
commit 01ff17d374
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibGUI/ScrollBar.cpp
View file

@ -236,7 +236,7 @@ void ScrollBar::paint_event(PaintEvent& event)
painter.add_clip_rect(event.rect()); painter.add_clip_rect(event.rect());
Component hovered_component_for_painting = m_hovered_component; Component hovered_component_for_painting = m_hovered_component;
if (m_pressed_component != Component::None && m_hovered_component != m_pressed_component) if (!has_scrubber() || (m_pressed_component != Component::None && m_hovered_component != m_pressed_component))
hovered_component_for_painting = Component::None; hovered_component_for_painting = Component::None;
painter.fill_rect_with_dither_pattern(rect(), palette().button().lightened(1.3f), palette().button()); painter.fill_rect_with_dither_pattern(rect(), palette().button().lightened(1.3f), palette().button());