mirror of
https://github.com/RGBCube/serenity
synced 2025-07-28 13:37:45 +00:00
Userland: Mark compilation-unit-only functions as static
This enables a nice warning in case a function becomes dead code.
This commit is contained in:
parent
5574d45eda
commit
0248ddc427
22 changed files with 85 additions and 83 deletions
|
@ -40,7 +40,7 @@ bool g_follow_symlinks = false;
|
|||
bool g_there_was_an_error = false;
|
||||
bool g_have_seen_action_command = false;
|
||||
|
||||
[[noreturn]] void fatal_error(const char* format, ...)
|
||||
[[noreturn]] static void fatal_error(const char* format, ...)
|
||||
{
|
||||
fputs("\033[31m", stderr);
|
||||
|
||||
|
@ -143,7 +143,7 @@ public:
|
|||
m_uid = passwd->pw_uid;
|
||||
} else {
|
||||
// Attempt to parse it as decimal UID.
|
||||
auto number = StringView(arg).to_uint();
|
||||
auto number = StringView(arg).to_uint();
|
||||
if (!number.has_value())
|
||||
fatal_error("Invalid user: \033[1m%s", arg);
|
||||
m_uid = number.value();
|
||||
|
@ -309,11 +309,11 @@ private:
|
|||
NonnullOwnPtr<Command> m_rhs;
|
||||
};
|
||||
|
||||
OwnPtr<Command> parse_complex_command(char* argv[]);
|
||||
static OwnPtr<Command> parse_complex_command(char* argv[]);
|
||||
|
||||
// Parse a simple command starting at optind; leave optind at its the last
|
||||
// argument. Return nullptr if we reach the end of arguments.
|
||||
OwnPtr<Command> parse_simple_command(char* argv[])
|
||||
static OwnPtr<Command> parse_simple_command(char* argv[])
|
||||
{
|
||||
StringView arg = argv[optind];
|
||||
|
||||
|
@ -352,14 +352,16 @@ OwnPtr<Command> parse_simple_command(char* argv[])
|
|||
}
|
||||
}
|
||||
|
||||
OwnPtr<Command> parse_complex_command(char* argv[])
|
||||
static OwnPtr<Command> parse_complex_command(char* argv[])
|
||||
{
|
||||
auto command = parse_simple_command(argv);
|
||||
|
||||
while (command && argv[optind] && argv[optind + 1]) {
|
||||
StringView arg = argv[++optind];
|
||||
|
||||
enum { And, Or } binary_operation = And;
|
||||
enum { And,
|
||||
Or } binary_operation
|
||||
= And;
|
||||
|
||||
if (arg == "-a") {
|
||||
optind++;
|
||||
|
@ -389,7 +391,7 @@ OwnPtr<Command> parse_complex_command(char* argv[])
|
|||
return command;
|
||||
}
|
||||
|
||||
NonnullOwnPtr<Command> parse_all_commands(char* argv[])
|
||||
static NonnullOwnPtr<Command> parse_all_commands(char* argv[])
|
||||
{
|
||||
auto command = parse_complex_command(argv);
|
||||
|
||||
|
@ -405,7 +407,7 @@ NonnullOwnPtr<Command> parse_all_commands(char* argv[])
|
|||
return make<AndCommand>(command.release_nonnull(), make<PrintCommand>());
|
||||
}
|
||||
|
||||
const char* parse_options(int argc, char* argv[])
|
||||
static const char* parse_options(int argc, char* argv[])
|
||||
{
|
||||
// Sadly, we can't use Core::ArgsParser, because find accepts arguments in
|
||||
// an extremely unusual format. We're going to try to use getopt(), though.
|
||||
|
@ -440,7 +442,7 @@ const char* parse_options(int argc, char* argv[])
|
|||
}
|
||||
}
|
||||
|
||||
void walk_tree(const char* root_path, Command& command)
|
||||
static void walk_tree(const char* root_path, Command& command)
|
||||
{
|
||||
command.evaluate(root_path);
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue