RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:38:11 +00:00
Code Issues Activity Actions

LibWeb: Optimize CSS::StyleDeclaration for size

Browse source 
We can reduce the amount of padding the compiler adds in order to
ensure data alignment of member variables by ordering the types in
a struct by size in decending order.

Found By PVS-Studio: https://pvs-studio.com/en/docs/warnings/v802/
This commit is contained in:
Brian Gianforcaro 2021-10-10 00:06:13 -07:00 • committed by Andreas Kling
parent 1b00ddf07e
commit 027cbe6b89
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -1834,9 +1834,9 @@ Optional<StyleProperty> Parser::convert_to_style_property(StyleDeclarationRule c
}
if (property_id == PropertyID::Custom) {
return StyleProperty { property_id, value.release_value(), declaration.m_name, declaration.m_important };
return StyleProperty { declaration.m_important, property_id, value.release_value(), declaration.m_name };
} else {
return StyleProperty { property_id, value.release_value(), {}, declaration.m_important };
return StyleProperty { declaration.m_important, property_id, value.release_value(), {} };
}
}