RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 06:58:11 +00:00
Code Issues Activity Actions

LibCore: Make Core::Object::add<ChildType> return a ChildType&

Browse source 
Since the returned object is now owned by the callee object, we can
simply vend a ChildType&. This allows us to use "." instead of "->"
at the call site, which is quite nice. :^)
This commit is contained in:
Andreas Kling 2020-03-04 19:07:55 +01:00
parent fb09b6a8ce
commit 028c011760
46 changed files with 1035 additions and 1039 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Libraries/LibGUI/ToolBar.cpp
View file

@ -59,21 +59,21 @@ void ToolBar::add_action(Action& action)
item->type = Item::Type::Action;
item->action = action;
auto button = add<Button>();
auto& button = add<Button>();
if (action.group() && action.group()->is_exclusive())
button->set_exclusive(true);
button->set_action(*item->action);
button->set_tooltip(item->action->text());
button.set_exclusive(true);
button.set_action(*item->action);
button.set_tooltip(item->action->text());
if (item->action->icon())
button->set_icon(item->action->icon());
button.set_icon(item->action->icon());
else
button->set_text(item->action->text());
button.set_text(item->action->text());
button->set_button_style(Gfx::ButtonStyle::CoolBar);
button->set_size_policy(SizePolicy::Fixed, SizePolicy::Fixed);
ASSERT(button->size_policy(Orientation::Horizontal) == SizePolicy::Fixed);
ASSERT(button->size_policy(Orientation::Vertical) == SizePolicy::Fixed);
button->set_preferred_size(m_button_size + 8, m_button_size + 8);
button.set_button_style(Gfx::ButtonStyle::CoolBar);
button.set_size_policy(SizePolicy::Fixed, SizePolicy::Fixed);
ASSERT(button.size_policy(Orientation::Horizontal) == SizePolicy::Fixed);
ASSERT(button.size_policy(Orientation::Vertical) == SizePolicy::Fixed);
button.set_preferred_size(m_button_size + 8, m_button_size + 8);
m_items.append(move(item));
}