mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 20:47:45 +00:00
LibWeb: Let Paintable perform the painting
This patch adds a bunch of Paintable subclasses, each corresponding to the Layout::Node subclasses that had a paint() override. All painting logic is moved from layout nodes into their corresponding paintables. Paintables are now created by asking a Layout::Box to produce one: static NonnullOwnPtr<Paintable> Layout::Box::create_paintable() Note that inline nodes still have their painting logic. Since they are not boxes, and all paintables have a corresponding box, we'll need to come up with some other solution for them.
This commit is contained in:
parent
f6497b64ac
commit
02b316fd5c
64 changed files with 1307 additions and 602 deletions
|
@ -6,7 +6,7 @@
|
|||
|
||||
#include <LibGfx/Painter.h>
|
||||
#include <LibWeb/Layout/CanvasBox.h>
|
||||
#include <LibWeb/Painting/Paintable.h>
|
||||
#include <LibWeb/Painting/CanvasPaintable.h>
|
||||
|
||||
namespace Web::Layout {
|
||||
|
||||
|
@ -25,21 +25,9 @@ void CanvasBox::prepare_for_replaced_layout()
|
|||
set_intrinsic_height(dom_node().height());
|
||||
}
|
||||
|
||||
void CanvasBox::paint(PaintContext& context, Painting::PaintPhase phase)
|
||||
OwnPtr<Painting::Paintable> CanvasBox::create_paintable() const
|
||||
{
|
||||
if (!is_visible())
|
||||
return;
|
||||
|
||||
ReplacedBox::paint(context, phase);
|
||||
|
||||
if (phase == Painting::PaintPhase::Foreground) {
|
||||
// FIXME: This should be done at a different level. Also rect() does not include padding etc!
|
||||
if (!context.viewport_rect().intersects(enclosing_int_rect(m_paint_box->absolute_rect())))
|
||||
return;
|
||||
|
||||
if (dom_node().bitmap())
|
||||
context.painter().draw_scaled_bitmap(rounded_int_rect(m_paint_box->absolute_rect()), *dom_node().bitmap(), dom_node().bitmap()->rect(), 1.0f, to_gfx_scaling_mode(computed_values().image_rendering()));
|
||||
}
|
||||
return Painting::CanvasPaintable::create(*this);
|
||||
}
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue