RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 13:37:44 +00:00
Code Issues Activity Actions

LibWeb: Let Paintable perform the painting

Browse source 
This patch adds a bunch of Paintable subclasses, each corresponding to
the Layout::Node subclasses that had a paint() override. All painting
logic is moved from layout nodes into their corresponding paintables.

Paintables are now created by asking a Layout::Box to produce one:

    static NonnullOwnPtr<Paintable> Layout::Box::create_paintable()

Note that inline nodes still have their painting logic. Since they
are not boxes, and all paintables have a corresponding box, we'll need
to come up with some other solution for them.
This commit is contained in:
Andreas Kling 2022-03-10 14:02:25 +01:00
parent f6497b64ac
commit 02b316fd5c
64 changed files with 1307 additions and 602 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/Layout/SVGBox.cpp
View file

@ -15,20 +15,4 @@ SVGBox::SVGBox(DOM::Document& document, SVG::SVGElement& element, NonnullRefPtr<
{
}
void SVGBox::before_children_paint(PaintContext& context, Painting::PaintPhase phase)
{
Node::before_children_paint(context, phase);
if (phase != Painting::PaintPhase::Foreground)
return;
context.svg_context().save();
}
void SVGBox::after_children_paint(PaintContext& context, Painting::PaintPhase phase)
{
Node::after_children_paint(context, phase);
if (phase != Painting::PaintPhase::Foreground)
return;
context.svg_context().restore();
}
}