RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 07:32:44 +00:00
Code Issues Activity Actions

Kernel/Graphics: Be more consistent about arguments passing

Browse source 
This fixes a bug that was reported on this discord server by
@ElectrodeYT - due to the confusion of passing arguments in different
orders, we messed up and triggered a page fault due to faulty sizes.
This commit is contained in:
Liav A 2021-05-17 00:02:47 +03:00 • committed by Linus Groh
parent ca9101e5f0
commit 02b73cb93d
8 changed files with 18 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/Graphics/Console/FramebufferConsole.h
View file

@ -14,13 +14,13 @@
namespace Kernel::Graphics {
class FramebufferConsole final : public Console {
public:
static NonnullRefPtr<FramebufferConsole> initialize(PhysicalAddress, size_t width, size_t height, size_t bpp);
static NonnullRefPtr<FramebufferConsole> initialize(PhysicalAddress, size_t width, size_t height, size_t pitch);
virtual size_t bytes_per_base_glyph() const override;
virtual size_t chars_per_line() const override;
virtual size_t max_column() const { return m_width / 8; }
virtual size_t max_row() const { return m_height / 8; }
virtual size_t max_column() const override { return m_width / 8; }
virtual size_t max_row() const override { return m_height / 8; }
virtual bool is_hardware_paged_capable() const override { return false; }
virtual bool has_hardware_cursor() const override { return false; }
@ -41,7 +41,7 @@ public:
protected:
void clear_glyph(size_t x, size_t y) const;
FramebufferConsole(PhysicalAddress, size_t width, size_t height, size_t bpp);
FramebufferConsole(PhysicalAddress, size_t width, size_t height, size_t pitch);
OwnPtr<Region> m_framebuffer_region;
PhysicalAddress m_framebuffer_address;
size_t m_pitch;