RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 22:57:34 +00:00
Code Issues Activity Actions

LibWeb: Make the link click hooks include the destination URL

Browse source 
We have all the context needed for relative URL resolution inside the
engine, so let's not make embedders worry about this.
This commit is contained in:
Andreas Kling 2020-07-06 19:41:10 +02:00
parent 1037a24076
commit 02c5e22f06
6 changed files with 23 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Applications/Browser/Tab.cpp
View file

@ -154,12 +154,10 @@ Tab::Tab()
update_bookmark_button(url.to_string());
};
m_page_view->on_link_click = [this](auto& href, auto& target, unsigned modifiers) {
m_page_view->on_link_click = [this](auto& url, auto& target, unsigned modifiers) {
if (target == "_blank" || modifiers == Mod_Ctrl) {
auto url = m_page_view->document()->complete_url(href);
on_tab_open_request(url);
} else {
auto url = m_page_view->document()->complete_url(href);
m_page_view->load(url);
}
};