RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:38:12 +00:00
Code Issues Activity Actions

HackStudio: Don't crash when saving is denied on build

Browse source 
When running build while having unsaved changes in HackStudio, it asks
whether you want to save the unsaved files with a separate dialog. When
you click "Yes" to saving the files, but deny the save-file dialog,
HackStudio would crash, since we were expecting there to be a file
to save to. Now, we check whether a file was picked, and if not, we
abort the build.
This commit is contained in:
david072 2023-10-31 20:40:00 +01:00 • committed by Sam Atkins
parent 88cc019275
commit 02cc2e0f8f
3 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/DevTools/HackStudio/HackStudioWidget.cpp
View file

@ -1678,7 +1678,8 @@ HackStudioWidget::ContinueDecision HackStudioWidget::warn_unsaved_changes(Deprec
if (result == GUI::MessageBox::ExecResult::Yes) {
for (auto& editor_wrapper : m_all_editor_wrappers) {
if (editor_wrapper->editor().document().is_modified()) {
editor_wrapper->save();
if (!editor_wrapper->save())
return ContinueDecision::No;
}
}
}