From 031005de2d62c2a6dd205ef11049bcc14b14fb42 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 12 Sep 2022 09:04:51 +0200 Subject: [PATCH] Ladybird: Remove some awkward camelCase signal names We use snake_case for everything except when we're forced by Qt to use their camelCase names. --- Ladybird/Tab.cpp | 6 +++--- Ladybird/WebView.cpp | 6 +++--- Ladybird/WebView.h | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/Ladybird/Tab.cpp b/Ladybird/Tab.cpp index 2654662634..a5e4fcf98e 100644 --- a/Ladybird/Tab.cpp +++ b/Ladybird/Tab.cpp @@ -59,16 +59,16 @@ Tab::Tab(QMainWindow* window) m_toolbar->addAction(m_home_action); m_toolbar->addWidget(m_location_edit); - QObject::connect(m_view, &WebView::linkHovered, [this](QString const& title) { + QObject::connect(m_view, &WebView::link_hovered, [this](QString const& title) { m_hover_label->setText(title); update_hover_label(); m_hover_label->show(); }); - QObject::connect(m_view, &WebView::linkUnhovered, [this] { + QObject::connect(m_view, &WebView::link_unhovered, [this] { m_hover_label->hide(); }); - QObject::connect(m_view, &WebView::loadStarted, [this](const URL& url) { + QObject::connect(m_view, &WebView::load_started, [this](const URL& url) { m_location_edit->setText(url.to_string().characters()); m_history.push(url, m_title.toUtf8().data()); }); diff --git a/Ladybird/WebView.cpp b/Ladybird/WebView.cpp index 9575bdfa98..e881fcc54e 100644 --- a/Ladybird/WebView.cpp +++ b/Ladybird/WebView.cpp @@ -173,7 +173,7 @@ public: virtual void page_did_start_loading(AK::URL const& url) override { - emit m_view.loadStarted(url); + emit m_view.load_started(url); } virtual void page_did_finish_loading(AK::URL const&) override @@ -252,12 +252,12 @@ public: virtual void page_did_hover_link(AK::URL const& url) override { - emit m_view.linkHovered(url.to_string().characters()); + emit m_view.link_hovered(url.to_string().characters()); } virtual void page_did_unhover_link() override { - emit m_view.linkUnhovered(); + emit m_view.link_unhovered(); } virtual void page_did_invalidate(Gfx::IntRect const&) override diff --git a/Ladybird/WebView.h b/Ladybird/WebView.h index f1a02fa901..2af499be19 100644 --- a/Ladybird/WebView.h +++ b/Ladybird/WebView.h @@ -50,9 +50,9 @@ public: Gfx::IntPoint to_widget(Gfx::IntPoint) const; signals: - void linkHovered(QString, int timeout = 0); - void linkUnhovered(); - void loadStarted(const URL&); + void link_hovered(QString, int timeout = 0); + void link_unhovered(); + void load_started(const URL&); void title_changed(QString); void favicon_changed(QIcon);