RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-08 17:47:35 +00:00
Code Issues Activity Actions

Browser+LibWeb+WebContent: Show style for pseudo-elements :^)

Browse source 
This expands the InspectorWidget::Selection to include an optional
PseudoElement, which is then passed over IPC to request style
information for it.

As noted, this has some pretty big limitations because pseudo-elements
don't have DOM nodes:
- Declared style has to be recalculated when it's requested.
- We don't display the computed style.
- We don't display custom properties.
This commit is contained in:
Sam Atkins 2022-03-04 16:29:05 +00:00 • committed by Andreas Kling
parent 2c970b9516
commit 0326ad34df
9 changed files with 69 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

35
Userland/Libraries/LibWeb/DOMTreeModel.cpp
View file

@ -182,22 +182,39 @@ void DOMTreeModel::map_dom_nodes_to_parent(JsonObject const* parent, JsonObject
});
}
GUI::ModelIndex DOMTreeModel::index_for_node(i32 node_id) const
GUI::ModelIndex DOMTreeModel::index_for_node(i32 node_id, Optional<Web::CSS::Selector::PseudoElement> pseudo_element) const
{
auto node = m_node_id_to_dom_node_map.get(node_id).value_or(nullptr);
if (node) {
auto* parent = get_parent(*node);
if (!parent)
return {};
auto parent_children = get_children(*parent);
for (size_t i = 0; i < parent_children->size(); i++) {
if (&parent_children->at(i).as_object() == node) {
return create_index(i, 0, node);
if (pseudo_element.has_value()) {
// Find pseudo-element child of the node.
auto node_children = get_children(*node);
for (size_t i = 0; i < node_children->size(); i++) {
auto& child = node_children->at(i).as_object();
if (!child.has("pseudo-element"))
continue;
auto child_pseudo_element = child.get("pseudo-element");
if (!child_pseudo_element.is_i32())
continue;
if (child_pseudo_element.as_i32() == to_underlying(pseudo_element.value()))
return create_index(i, 0, &child);
}
} else {
auto* parent = get_parent(*node);
if (!parent)
return {};
auto parent_children = get_children(*parent);
for (size_t i = 0; i < parent_children->size(); i++) {
if (&parent_children->at(i).as_object() == node) {
return create_index(i, 0, node);
}
}
}
}
dbgln("Didn't find index for node {}!", node_id);
dbgln("Didn't find index for node {}, pseudo-element {}!", node_id, pseudo_element.has_value() ? CSS::pseudo_element_name(pseudo_element.value()) : "NONE");
return {};
}