RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:48:11 +00:00
Code Issues Activity Actions

LibWeb: Implement more spec-compliant iframe/frame attribute processing

Browse source 
We're still missing the lazy loading attribute handling, and once we hit
the navigation step, we fall back to totally ad-hoc behavior instead of
going all the way with a Fetch Request.
This commit is contained in:
Andreas Kling 2022-09-19 13:34:36 +02:00
parent 0810e77d77
commit 03375a3dc9
4 changed files with 168 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h
View file

@ -18,6 +18,11 @@ public:
virtual RefPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
// https://html.spec.whatwg.org/multipage/urls-and-fetching.html#will-lazy-load-element-steps
bool will_lazy_load_element() const;
void set_current_navigation_was_lazy_loaded(bool value) { m_current_navigation_was_lazy_loaded = value; }
private:
HTMLIFrameElement(DOM::Document&, DOM::QualifiedName);
@ -25,7 +30,13 @@ private:
virtual void removed_from(Node*) override;
virtual void parse_attribute(FlyString const& name, String const& value) override;
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes
void process_the_iframe_attributes(bool initial_insertion = false);
void load_src(String const&);
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#current-navigation-was-lazy-loaded
bool m_current_navigation_was_lazy_loaded { false };
};
void run_iframe_load_event_steps(HTML::HTMLIFrameElement&);