RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:37:35 +00:00
Code Issues Activity Actions

HexEditor: Remove unused readonly flag

Browse source 
`HexEditor::set_readonly` was never called, even though
`HexEditor::is_readonly` was occasionally queried -- so it's entirely
been removed.
This commit is contained in:
James Puleo 2022-07-28 02:49:15 -04:00 • committed by Tim Flynn
parent 8695ae4c50
commit 035d63f528
2 changed files with 1 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Applications/HexEditor/HexEditor.cpp
View file

@ -49,13 +49,6 @@ HexEditor::HexEditor()
m_blink_timer->start(); m_blink_timer->start();
} }
void HexEditor::set_readonly(bool readonly)
{
if (m_readonly == readonly)
return;
m_readonly = readonly;
}
bool HexEditor::open_new_file(size_t size) bool HexEditor::open_new_file(size_t size)
{ {
auto maybe_buffer = ByteBuffer::create_zeroed(size); auto maybe_buffer = ByteBuffer::create_zeroed(size);
@ -460,7 +453,7 @@ void HexEditor::keydown_event(GUI::KeyEvent& event)
return; return;
} }
if (!is_readonly() && !event.ctrl() && !event.alt() && !event.text().is_empty()) { if (!event.ctrl() && !event.alt() && !event.text().is_empty()) {
if (m_edit_mode == EditMode::Hex) { if (m_edit_mode == EditMode::Hex) {
hex_mode_keydown_event(event); hex_mode_keydown_event(event);
} else { } else {

4
Userland/Applications/HexEditor/HexEditor.h
View file

@ -32,9 +32,6 @@ public:
virtual ~HexEditor() override = default; virtual ~HexEditor() override = default;
bool is_readonly() const { return m_readonly; }
void set_readonly(bool);
size_t buffer_size() const { return m_document->size(); } size_t buffer_size() const { return m_document->size(); }
bool open_new_file(size_t size); bool open_new_file(size_t size);
void open_file(NonnullRefPtr<Core::File> file); void open_file(NonnullRefPtr<Core::File> file);
@ -74,7 +71,6 @@ protected:
virtual void keydown_event(GUI::KeyEvent&) override; virtual void keydown_event(GUI::KeyEvent&) override;
private: private:
bool m_readonly { false };
size_t m_line_spacing { 4 }; size_t m_line_spacing { 4 };
size_t m_content_length { 0 }; size_t m_content_length { 0 };
size_t m_bytes_per_row { 16 }; size_t m_bytes_per_row { 16 };