From 03725c613530735de4f381bad3b4fac3179fffc2 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 6 Oct 2019 21:01:03 +0200 Subject: [PATCH] GFilePicker: Fix crash in get_save_filepath() Oops, don't create GFilePickers on the stack! Spotted by Sergey ^) --- Libraries/LibGUI/GFilePicker.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibGUI/GFilePicker.cpp b/Libraries/LibGUI/GFilePicker.cpp index 312612895e..9d649cf5af 100644 --- a/Libraries/LibGUI/GFilePicker.cpp +++ b/Libraries/LibGUI/GFilePicker.cpp @@ -30,10 +30,10 @@ Optional GFilePicker::get_open_filepath() Optional GFilePicker::get_save_filepath(const String& title, const String& extension) { - GFilePicker picker(Mode::Save, String::format("%s.%s", title.characters(), extension.characters())); + auto picker = GFilePicker::construct(Mode::Save, String::format("%s.%s", title.characters(), extension.characters())); - if (picker.exec() == GDialog::ExecOK) { - String file_path = picker.selected_file().string(); + if (picker->exec() == GDialog::ExecOK) { + String file_path = picker->selected_file().string(); if (file_path.is_null()) return {};