RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 19:12:43 +00:00
Code Issues Activity Actions

LibJS: Remove Object::value_of()

Browse source 
Being really close to Object.prototype.valueOf() name wise makes this
unnecessarily confusing - while it sometimes serves as the
implementation of a valueOf() function, it's an abstraction which the
spec doesn't have.
Use the appropriate getters to retrieve specific internal slots instead,
most commonly [[FooData]] from the primitive wrapper objects.
For the Object class specifically, use the Value(Object*) ctor instead.
This commit is contained in:
Linus Groh 2021-12-10 22:50:02 +00:00
parent 07c5419a82
commit 038d354b5d
14 changed files with 20 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/js.cpp
View file

@ -760,7 +760,7 @@ static void print_primitive_wrapper_object(FlyString const& name, JS::Object con
// BooleanObject, NumberObject, StringObject
print_type(name);
js_out(" ");
print_value(object.value_of(), seen_objects);
print_value(&object, seen_objects);
}
static void print_value(JS::Value value, HashTable<JS::Object*>& seen_objects)