From 03910962863c2d826a15aff75fd8d1a3890a33b4 Mon Sep 17 00:00:00 2001 From: hanaa12G Date: Sun, 29 Oct 2023 16:42:45 +0700 Subject: [PATCH] HackStudio: Pass the correct `VariableInfo` address to `create_index` Previously, we tried to store `VariableInfo` to `ModelIndex` internal data, but accidently stored address of wrapper class `NonnullOwnPtr`. When we retrieved it later in `VariablesModel::data()` it made program to crash. This allows us to run debug normally after setting any break point in `HackStudio`. --- Userland/DevTools/HackStudio/Debugger/VariablesModel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/DevTools/HackStudio/Debugger/VariablesModel.cpp b/Userland/DevTools/HackStudio/Debugger/VariablesModel.cpp index 5b4fb0dabf..2ea9d5eb19 100644 --- a/Userland/DevTools/HackStudio/Debugger/VariablesModel.cpp +++ b/Userland/DevTools/HackStudio/Debugger/VariablesModel.cpp @@ -15,7 +15,7 @@ GUI::ModelIndex VariablesModel::index(int row, int column, const GUI::ModelIndex if (!parent_index.is_valid()) { if (static_cast(row) >= m_variables.size()) return {}; - return create_index(row, column, &m_variables[row]); + return create_index(row, column, m_variables[row].ptr()); } auto* parent = static_cast(parent_index.internal_data()); if (static_cast(row) >= parent->members.size())