From 03a27bc69348c90a39fccf05702aa36870204684 Mon Sep 17 00:00:00 2001 From: asynts Date: Sun, 20 Sep 2020 21:01:08 +0200 Subject: [PATCH] LibGUI: Remove unnecessary type cast in JsonArrayModel. Since TCP sequence numbers are randomly choosen 32-bit numbers, it often happend that the most significant bit was set. The cast to a 32-bit signed integer then made the number negative. Thus TCP sequence were shown negative in the SystemMonitor every so often. --- Libraries/LibGUI/JsonArrayModel.cpp | 2 +- Libraries/LibGUI/JsonArrayModel.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/LibGUI/JsonArrayModel.cpp b/Libraries/LibGUI/JsonArrayModel.cpp index 0837dbcb55..31e6430200 100644 --- a/Libraries/LibGUI/JsonArrayModel.cpp +++ b/Libraries/LibGUI/JsonArrayModel.cpp @@ -107,7 +107,7 @@ Variant JsonArrayModel::data(const ModelIndex& index, ModelRole role) const if (field_spec.massage_for_display) return field_spec.massage_for_display(object); if (data.is_number()) - return data.to_i32(); + return data; return object.get(json_field_name).to_string(); } diff --git a/Libraries/LibGUI/JsonArrayModel.h b/Libraries/LibGUI/JsonArrayModel.h index 9b19fb81e0..1c44917dcf 100644 --- a/Libraries/LibGUI/JsonArrayModel.h +++ b/Libraries/LibGUI/JsonArrayModel.h @@ -64,7 +64,7 @@ public: return adopt(*new JsonArrayModel(json_path, move(fields))); } - virtual ~JsonArrayModel() override {} + virtual ~JsonArrayModel() override { } virtual int row_count(const ModelIndex& = ModelIndex()) const override { return m_array.size(); } virtual int column_count(const ModelIndex& = ModelIndex()) const override { return m_fields.size(); }