RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:47:35 +00:00
Code Issues Activity Actions

Kernel: Move NVMeQueue's m_cq_lock to NVMePollQueue

Browse source 
It's only used by that subclass, so there's no reason for it to be
defined as part of the parent class.
This commit is contained in:
Idan Horowitz 2024-02-09 17:26:56 +02:00 • committed by Andreas Kling
parent 45aee20ea9
commit 03cb3e5370
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Devices/Storage/NVMe/NVMePollQueue.h
View file

@ -18,5 +18,8 @@ public:
protected: protected:
NVMePollQueue(NonnullOwnPtr<Memory::Region> rw_dma_region, NonnullRefPtr<Memory::PhysicalPage> rw_dma_page, u16 qid, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, OwnPtr<Memory::Region> sq_dma_region, Doorbell db_regs); NVMePollQueue(NonnullOwnPtr<Memory::Region> rw_dma_region, NonnullRefPtr<Memory::PhysicalPage> rw_dma_page, u16 qid, u32 q_depth, OwnPtr<Memory::Region> cq_dma_region, OwnPtr<Memory::Region> sq_dma_region, Doorbell db_regs);
private:
Spinlock<LockRank::Interrupts> m_cq_lock {};
}; };
} }

1
Kernel/Devices/Storage/NVMe/NVMeQueue.h
View file

@ -112,7 +112,6 @@ private:
} }
protected: protected:
Spinlock<LockRank::Interrupts> m_cq_lock {};
SpinlockProtected<HashMap<u16, NVMeIO>, LockRank::None> m_requests; SpinlockProtected<HashMap<u16, NVMeIO>, LockRank::None> m_requests;
NonnullOwnPtr<Memory::Region> m_rw_dma_region; NonnullOwnPtr<Memory::Region> m_rw_dma_region;