From 03e13715acbf8b9b703062d094e7862bf7c7b2e6 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Tue, 3 May 2022 21:23:12 +0200 Subject: [PATCH] LibJS: Update two comments saying "completion value" This is an editorial change in the ECMA-262 spec. See: https://github.com/tc39/ecma262/commit/7913cea --- .../Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp | 2 +- Userland/Libraries/LibJS/Runtime/VM.cpp | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp b/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp index 4fcaa64458..3f432ee052 100644 --- a/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp +++ b/Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp @@ -768,7 +768,7 @@ void async_block_start(VM& vm, NonnullRefPtr const& async_body, Promi // 6. Assert: When we return here, asyncContext has already been removed from the execution context stack and runningContext is the currently running execution context. VERIFY(&vm.running_execution_context() == &running_context); - // 7. Assert: result is a normal completion with a value of unused. The possible sources of completion values are Await or, if the async function doesn't await anything, step 3.g above. + // 7. Assert: result is a normal completion with a value of unused. The possible sources of this value are Await or, if the async function doesn't await anything, step 3.g above. VERIFY(result.has_value() && result.value().is_undefined()); // 8. Return unused. diff --git a/Userland/Libraries/LibJS/Runtime/VM.cpp b/Userland/Libraries/LibJS/Runtime/VM.cpp index 7752f29674..5f977f6251 100644 --- a/Userland/Libraries/LibJS/Runtime/VM.cpp +++ b/Userland/Libraries/LibJS/Runtime/VM.cpp @@ -934,10 +934,9 @@ void VM::import_module_dynamically(ScriptOrModule referencing_script_or_module, // - At some future time, the host environment must perform FinishDynamicImport(referencingScriptOrModule, moduleRequest, promiseCapability, promise), // where promise is a Promise resolved with undefined. // - Any subsequent call to HostResolveImportedModule after FinishDynamicImport has completed, - // given the arguments referencingScriptOrModule and moduleRequest, must complete normally. - // - The completion value of any subsequent call to HostResolveImportedModule after FinishDynamicImport has completed, - // given the arguments referencingScriptOrModule and moduleRequest, must be a module which has already been evaluated, - // i.e. whose Evaluate concrete method has already been called and returned a normal completion. + // given the arguments referencingScriptOrModule and specifier, must return a normal completion + // containing a module which has already been evaluated, i.e. whose Evaluate concrete method has + // already been called and returned a normal completion. // Failure path: // - At some future time, the host environment must perform // FinishDynamicImport(referencingScriptOrModule, moduleRequest, promiseCapability, promise),