mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 03:17:35 +00:00
Userland: Fix null-pointer deref on unknown user/group in chown/chgrp
We can't just blindly dereference the result of getpwnam()/getgrnam()! Fixes #1625.
This commit is contained in:
parent
54cb1e36b6
commit
040ba77d44
2 changed files with 11 additions and 11 deletions
|
@ -57,23 +57,23 @@ int main(int argc, char** argv)
|
|||
bool ok;
|
||||
new_uid = parts[0].to_uint(ok);
|
||||
if (!ok) {
|
||||
new_uid = getpwnam(parts[0].characters())->pw_uid;
|
||||
|
||||
if (!new_uid) {
|
||||
fprintf(stderr, "Invalid uid: '%s'\n", parts[0].characters());
|
||||
auto* passwd = getpwnam(parts[0].characters());
|
||||
if (!passwd) {
|
||||
fprintf(stderr, "Unknown user '%s'\n", parts[0].characters());
|
||||
return 1;
|
||||
}
|
||||
new_uid = passwd->pw_uid;
|
||||
}
|
||||
|
||||
if (parts.size() == 2) {
|
||||
new_gid = parts[1].to_uint(ok);
|
||||
if (!ok) {
|
||||
new_gid = getgrnam(parts[1].characters())->gr_gid;
|
||||
|
||||
auto* group = getgrnam(parts[1].characters());
|
||||
if (!new_gid) {
|
||||
fprintf(stderr, "Invalid gid: '%s'\n", parts[1].characters());
|
||||
fprintf(stderr, "Unknown group '%s'\n", parts[1].characters());
|
||||
return 1;
|
||||
}
|
||||
new_gid = group->gr_gid;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue