RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:47:44 +00:00
Code Issues Activity Actions

LibJS: Implement SetDefaultGlobalBindings as a standalone function

Browse source 
Instead of hardcoding all the property definitions in GlobalObject's
initialize() function, make it the standalone AO it is supposed to be
that can then be used by other global objects that don't inherit from
JS::GlobalObject.
This commit is contained in:
Linus Groh 2022-08-28 17:33:01 +01:00
parent e3804e6426
commit 040e3abb1d
3 changed files with 103 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Realm.cpp
View file

@ -71,11 +71,11 @@ ThrowCompletionOr<NonnullOwnPtr<ExecutionContext>> Realm::initialize_host_define
// 9. Perform SetRealmGlobalObject(realm, global, thisValue).
realm->set_global_object(global, this_value);
// NOTE: Steps 10 & 11 are somewhat ad-hoc, since we store intrinsics on the global object.
// 10. Let globalObj be ? SetDefaultGlobalBindings(realm).
auto& global_object = set_default_global_bindings(*realm);
// 11. Create any host-defined global object properties on globalObj.
realm->global_object().initialize(*realm);
global_object.initialize(*realm);
// 12. Return unused.
return new_context;