1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:47:47 +00:00

LibJS: Change Intl's PatternPartition record to hold a String value

It was previously holding a StringView, which was either a view into a
LibUnicode-generated string or a string passed from the user.

Intl.NumberFormat will need this record to hold internally-created
strings, so a StringView will not suffice (the way the steps are laid
out, that view will ultimately end up dangling).

This shouldn't be too wasteful since the StringView it was holding was
converted to a String eventually anyways.
This commit is contained in:
Timothy Flynn 2021-11-10 12:48:07 -05:00 committed by Linus Groh
parent be69eae651
commit 0469006263
2 changed files with 7 additions and 7 deletions

View file

@ -31,7 +31,7 @@ struct LocaleResult {
struct PatternPartition {
StringView type;
StringView value;
String value;
};
Optional<Unicode::LocaleID> is_structurally_valid_language_tag(StringView locale);