RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 08:28:11 +00:00
Code Issues Activity Actions

LibJS: Remove ConsoleMessage from LibJS

Browse source 
We don't need to store the past messages in LibJS.
We'll implement a way to let LibJS users expand the vanilla Console.
This commit is contained in:
Emanuele Torre 2020-05-04 12:02:16 +02:00 • committed by Andreas Kling
parent 7dd49047f3
commit 046f9cf115
3 changed files with 20 additions and 84 deletions
Download patch file Download diff file Expand all files Collapse all files

33
Userland/js.cpp
View file

@ -388,37 +388,6 @@ void sigint_handler()
interrupt_interpreter();
}
void console_message_handler(JS::ConsoleMessage& message)
{
switch (message.kind) {
case JS::ConsoleMessageKind::Count:
case JS::ConsoleMessageKind::Log:
case JS::ConsoleMessageKind::Info:
case JS::ConsoleMessageKind::Trace:
puts(message.text.characters());
break;
case JS::ConsoleMessageKind::Debug:
printf("\033[36;1m");
puts(message.text.characters());
printf("\033[0m");
break;
case JS::ConsoleMessageKind::Warn:
printf("\033[33;1m");
puts(message.text.characters());
printf("\033[0m");
break;
case JS::ConsoleMessageKind::Error:
printf("\033[31;1m");
puts(message.text.characters());
printf("\033[0m");
break;
case JS::ConsoleMessageKind::Clear:
printf("\033[3J\033[H\033[2J");
fflush(stdout);
break;
}
};
int main(int argc, char** argv)
{
bool gc_on_every_allocation = false;
@ -446,7 +415,6 @@ int main(int argc, char** argv)
if (script_path == nullptr) {
interpreter = JS::Interpreter::create<ReplObject>();
interpreter->console().on_new_message = console_message_handler;
interpreter->heap().set_should_collect_on_every_allocation(gc_on_every_allocation);
if (test_mode)
enable_test_mode(*interpreter);
@ -671,7 +639,6 @@ int main(int argc, char** argv)
repl(*interpreter);
} else {
interpreter = JS::Interpreter::create<JS::GlobalObject>();
interpreter->console().on_new_message = console_message_handler;
interpreter->heap().set_should_collect_on_every_allocation(gc_on_every_allocation);
if (test_mode)
enable_test_mode(*interpreter);