From 04897f6842cb0bce3c02e5d9683fe5c7f0f00441 Mon Sep 17 00:00:00 2001 From: Max Wipfli Date: Fri, 4 Jun 2021 11:04:16 +0200 Subject: [PATCH] LibSQL: Fix off-by-one error in SyntaxHighlighter This changes the SQL SyntaxHighlighter to conform to the now-fixed rendering of syntax highlighting spans in GUI::TextEditor. --- Userland/Libraries/LibSQL/SyntaxHighlighter.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibSQL/SyntaxHighlighter.cpp b/Userland/Libraries/LibSQL/SyntaxHighlighter.cpp index ab1fb5bc6a..5d53f4e079 100644 --- a/Userland/Libraries/LibSQL/SyntaxHighlighter.cpp +++ b/Userland/Libraries/LibSQL/SyntaxHighlighter.cpp @@ -52,8 +52,8 @@ void SyntaxHighlighter::rehighlight(Palette const& palette) return; GUI::TextPosition position { token.line_number() - 1, token.line_column() - 1 }; - for (size_t i = 0; i < str.length() - 1; ++i) { - if (str[i] == '\n') { + for (char c : str) { + if (c == '\n') { position.set_line(position.line() + 1); position.set_column(0); } else