From 04979865722ab558fdc4d909dbb9cecd40869897 Mon Sep 17 00:00:00 2001 From: Gunnar Beutner Date: Mon, 12 Apr 2021 18:29:36 +0200 Subject: [PATCH] LibC: Use dbgln() in strerror() and strsignal() Printing error messages to stdout can have unintended side effects depending on what the program is doing. --- Userland/Libraries/LibC/string.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibC/string.cpp b/Userland/Libraries/LibC/string.cpp index 596e04c95e..cd7af7554f 100644 --- a/Userland/Libraries/LibC/string.cpp +++ b/Userland/Libraries/LibC/string.cpp @@ -24,6 +24,7 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#include #include #include #include @@ -376,7 +377,7 @@ int sys_nerr = EMAXERRNO; char* strerror(int errnum) { if (errnum < 0 || errnum >= EMAXERRNO) { - printf("strerror() missing string for errnum=%d\n", errnum); + dbgln("strerror() missing string for errnum={}", errnum); return const_cast("Unknown error"); } return const_cast(sys_errlist[errnum]); @@ -385,7 +386,7 @@ char* strerror(int errnum) char* strsignal(int signum) { if (signum >= NSIG) { - printf("strsignal() missing string for signum=%d\n", signum); + dbgln("strsignal() missing string for signum={}", signum); return const_cast("Unknown signal"); } return const_cast(sys_siglist[signum]);