RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 03:57:43 +00:00
Code Issues Activity Actions

LibHTML: <a href="#foo"> should prefer any element type with id=foo

Browse source 
It turns out that other engines also prefer <h1 id=x> over <a name=x>.
So we can just use get_element_by_id() directly without worrying about
the type of element we find.
This commit is contained in:
Andreas Kling 2019-10-21 12:12:23 +02:00
parent 8e710b16de
commit 04b94a7695
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibHTML/HtmlView.cpp
View file

@ -319,11 +319,7 @@ void HtmlView::scroll_to_anchor(const StringView& name)
if (!document()) if (!document())
return; return;
const HTMLAnchorElement* element = nullptr; auto* element = document()->get_element_by_id(name);
if (auto* candidate = document()->get_element_by_id(name)) {
if (is<HTMLAnchorElement>(*candidate))
element = to<HTMLAnchorElement>(candidate);
}
if (!element) { if (!element) {
auto candidates = document()->get_elements_by_name(name); auto candidates = document()->get_elements_by_name(name);
for (auto* candidate : candidates) { for (auto* candidate : candidates) {