RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:07:35 +00:00
Code Issues Activity Actions

FileManager: Make DirectoryView API's take String instead of StringView

Browse source
This commit is contained in:
Andreas Kling 2021-04-17 00:46:13 +02:00
parent 1f684c8123
commit 0528dc9b87
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/FileManager/DirectoryView.cpp
View file

@ -392,7 +392,7 @@ void DirectoryView::set_view_mode(ViewMode mode)
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
} }
void DirectoryView::add_path_to_history(const StringView& path) void DirectoryView::add_path_to_history(String path)
{ {
if (m_path_history.size() && m_path_history.at(m_path_history_position) == path) if (m_path_history.size() && m_path_history.at(m_path_history_position) == path)
return; return;
@ -400,11 +400,11 @@ void DirectoryView::add_path_to_history(const StringView& path)
if (m_path_history_position < m_path_history.size()) if (m_path_history_position < m_path_history.size())
m_path_history.resize(m_path_history_position + 1); m_path_history.resize(m_path_history_position + 1);
m_path_history.append(path); m_path_history.append(move(path));
m_path_history_position = m_path_history.size() - 1; m_path_history_position = m_path_history.size() - 1;
} }
void DirectoryView::open(const StringView& path) void DirectoryView::open(String const& path)
{ {
auto real_path = Core::File::real_path_for(path); auto real_path = Core::File::real_path_for(path);

4
Userland/Applications/FileManager/DirectoryView.h
View file

@ -67,7 +67,7 @@ public:
virtual ~DirectoryView() override; virtual ~DirectoryView() override;
void open(const StringView& path); void open(String const& path);
String path() const { return model().root_path(); } String path() const { return model().root_path(); }
void open_parent_directory(); void open_parent_directory();
void open_previous_directory(); void open_previous_directory();
@ -173,7 +173,7 @@ private:
NonnullRefPtr<GUI::SortingProxyModel> m_sorting_model; NonnullRefPtr<GUI::SortingProxyModel> m_sorting_model;
size_t m_path_history_position { 0 }; size_t m_path_history_position { 0 };
Vector<String> m_path_history; Vector<String> m_path_history;
void add_path_to_history(const StringView& path); void add_path_to_history(String);
RefPtr<GUI::Label> m_error_label; RefPtr<GUI::Label> m_error_label;