From 052a101cc500813fc233d69f7104b7a509b9c950 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 10 Feb 2019 14:47:09 +0100 Subject: [PATCH] Terminal: Fix lagged full flush after scrolling the whole buffer. Now that we're using the lazy rendering model of LibGUI, we can't wait until paint_event() to decide how much we want to update. :^) --- Applications/Terminal/Terminal.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Applications/Terminal/Terminal.cpp b/Applications/Terminal/Terminal.cpp index 68ce1d4691..d62d258741 100644 --- a/Applications/Terminal/Terminal.cpp +++ b/Applications/Terminal/Terminal.cpp @@ -400,6 +400,7 @@ void Terminal::scroll_up() m_lines[row - 1] = m_lines[row]; m_lines[m_rows - 1] = new Line(m_columns); ++m_rows_to_scroll_backing_store; + m_need_full_flush = true; } void Terminal::set_cursor(unsigned a_row, unsigned a_column) @@ -659,7 +660,6 @@ void Terminal::paint_event(GPaintEvent&) painter.target()->scanline(second_scanline), scanlines_to_copy * m_pixel_width ); - m_need_full_flush = true; line(max(0, m_cursor_row - m_rows_to_scroll_backing_store)).dirty = true; } m_rows_to_scroll_backing_store = 0;