From 0558eb6d2fcfbd53571acc6ea9f0d8b2999c803b Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Mon, 16 May 2022 20:35:13 +0100 Subject: [PATCH] LibJS: Swap until/since arguments to DifferenceTemporalZonedDateTime This is an editorial change in the Temporal spec. See: https://github.com/tc39/proposal-temporal/commit/b911bc9 --- .../Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp index 18b0da79ab..2776c2ad71 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp @@ -244,8 +244,7 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::until) // 2. Perform ? RequireInternalSlot(temporalTime, [[InitializedTemporalTime]]). auto* temporal_time = TRY(typed_this_object(global_object)); - // 3. Return ? DifferenceTemporalPlainTime(since, temporalTime, other, options). - // FIXME: until, not since (spec issue, see https://github.com/tc39/proposal-temporal/pull/2183) + // 3. Return ? DifferenceTemporalPlainTime(until, temporalTime, other, options). return TRY(difference_temporal_plain_time(global_object, DifferenceOperation::Until, *temporal_time, other, options)); } @@ -259,8 +258,7 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::since) // 2. Perform ? RequireInternalSlot(temporalTime, [[InitializedTemporalTime]]). auto* temporal_time = TRY(typed_this_object(global_object)); - // 3. Return ? DifferenceTemporalPlainTime(until, temporalTime, other, options). - // FIXME: since, not until (spec issue, see https://github.com/tc39/proposal-temporal/pull/2183) + // 3. Return ? DifferenceTemporalPlainTime(since, temporalTime, other, options). return TRY(difference_temporal_plain_time(global_object, DifferenceOperation::Since, *temporal_time, other, options)); }