From 056ffa4abb1480830b9887d1a73b6fdbc87747eb Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Fri, 26 Mar 2021 19:35:54 +0100 Subject: [PATCH] LibWeb: Call requestAnimationFrame() callback with undefined this value We were leaking an empty value via the callback's this value: requestAnimationFrame(function () { this; // <-- empty value }); --- Userland/Libraries/LibWeb/DOM/Window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/DOM/Window.cpp b/Userland/Libraries/LibWeb/DOM/Window.cpp index 62c327fd75..52607e2ab8 100644 --- a/Userland/Libraries/LibWeb/DOM/Window.cpp +++ b/Userland/Libraries/LibWeb/DOM/Window.cpp @@ -140,7 +140,7 @@ i32 Window::request_animation_frame(JS::Function& callback) auto& function = const_cast(static_cast(*handle.cell())); auto& vm = function.vm(); fake_timestamp += 10; - [[maybe_unused]] auto rc = vm.call(function, {}, JS::Value(fake_timestamp)); + [[maybe_unused]] auto rc = vm.call(function, JS::js_undefined(), JS::Value(fake_timestamp)); if (vm.exception()) vm.clear_exception(); GUI::DisplayLink::unregister_callback(link_id);