RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:38:12 +00:00
Code Issues Activity Actions

LibJS: Convert Console to use MarkedVector<Value>

Browse source 
Using a Vector<Value> is unsafe as GC cannot see the stored values.
This is then vended to outside users of ConsoleClient, e.g. LibWeb and
WebContent, which is then outside of LibJS's control.

An example issue is if the client stores it for later use and forgets
to visit the stored values, meaning they can be destroyed at any time.
We can save the client from this by vending a MarkedVector<Value> to
them.
This commit is contained in:
Luke Wilde 2022-05-07 00:20:22 +01:00 • committed by Linus Groh
parent f04911e777
commit 05748ed607
5 changed files with 42 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Console.h
View file

@ -61,7 +61,7 @@ public:
GlobalObject const& global_object() const { return m_global_object; }
VM& vm();
Vector<Value> vm_arguments();
MarkedVector<Value> vm_arguments();
HashMap<String, unsigned>& counters() { return m_counters; }
HashMap<String, unsigned> const& counters() const { return m_counters; }
@ -86,7 +86,7 @@ public:
void output_debug_message(LogLevel log_level, String output) const;
private:
ThrowCompletionOr<String> value_vector_to_string(Vector<Value>&);
ThrowCompletionOr<String> value_vector_to_string(MarkedVector<Value> const&);
ThrowCompletionOr<String> format_time_since(Core::ElapsedTimer timer);
GlobalObject& m_global_object;
@ -104,10 +104,10 @@ public:
{
}
using PrinterArguments = Variant<Console::Group, Console::Trace, Vector<Value>>;
using PrinterArguments = Variant<Console::Group, Console::Trace, MarkedVector<Value>>;
ThrowCompletionOr<Value> logger(Console::LogLevel log_level, Vector<Value>& args);
ThrowCompletionOr<Vector<Value>> formatter(Vector<Value>& args);
ThrowCompletionOr<Value> logger(Console::LogLevel log_level, MarkedVector<Value> const& args);
ThrowCompletionOr<MarkedVector<Value>> formatter(MarkedVector<Value> const& args);
virtual ThrowCompletionOr<Value> printer(Console::LogLevel log_level, PrinterArguments) = 0;
virtual void clear() = 0;