RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:27:35 +00:00
Code Issues Activity Actions

LibWeb: Replace last couple of StyleValue casts with as_foo()

Browse source
This commit is contained in:
Sam Atkins 2021-09-24 11:37:35 +01:00 • committed by Andreas Kling
parent a83b620fa6
commit 058d44dcae
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -2095,7 +2095,7 @@ RefPtr<StyleValue> Parser::parse_flex_value(ParsingContext const& context, Vecto
return nullptr; return nullptr;
// Zero is a valid value for basis, but only if grow and shrink are already specified. // Zero is a valid value for basis, but only if grow and shrink are already specified.
if (value->is_numeric() && static_cast<NumericStyleValue&>(*value).value() == 0) { if (value->has_number() && value->to_number() == 0) {
if (flex_grow && flex_shrink && !flex_basis) { if (flex_grow && flex_shrink && !flex_basis) {
flex_basis = LengthStyleValue::create(Length(0, Length::Type::Px)); flex_basis = LengthStyleValue::create(Length(0, Length::Type::Px));
continue; continue;

4
Userland/Libraries/LibWeb/Layout/Node.cpp
View file

@ -220,7 +220,7 @@ void NodeWithStyle::apply_style(const CSS::StyleProperties& specified_style)
auto bgimage = specified_style.property(CSS::PropertyID::BackgroundImage); auto bgimage = specified_style.property(CSS::PropertyID::BackgroundImage);
if (bgimage.has_value() && bgimage.value()->is_image()) { if (bgimage.has_value() && bgimage.value()->is_image()) {
m_background_image = static_ptr_cast<CSS::ImageStyleValue>(bgimage.value()); m_background_image = bgimage.value()->as_image();
} }
// FIXME: BorderXRadius properties are now BorderRadiusStyleValues, so make use of that. // FIXME: BorderXRadius properties are now BorderRadiusStyleValues, so make use of that.
@ -374,7 +374,7 @@ void NodeWithStyle::apply_style(const CSS::StyleProperties& specified_style)
// FIXME: Converting to pixels isn't really correct - values should be in "user units" // FIXME: Converting to pixels isn't really correct - values should be in "user units"
// https://svgwg.org/svg2-draft/coords.html#TermUserUnits // https://svgwg.org/svg2-draft/coords.html#TermUserUnits
if (stroke_width.value()->is_numeric()) if (stroke_width.value()->is_numeric())
computed_values.set_stroke_width(CSS::Length::make_px(static_cast<CSS::NumericStyleValue const&>(*stroke_width.value()).value())); computed_values.set_stroke_width(CSS::Length::make_px(stroke_width.value()->to_number()));
else else
computed_values.set_stroke_width(stroke_width.value()->to_length()); computed_values.set_stroke_width(stroke_width.value()->to_length());
} }