RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 21:22:46 +00:00
Code Issues Activity Actions

Kernel: Don't turn private read-only regions into shared ones on fork

Browse source 
Even if they are read-only now, they can be mprotect(PROT_WRITE)'d in
the future, so we have to make sure they are CoW mapped.
This commit is contained in:
Andreas Kling 2019-12-15 16:53:46 +01:00
parent 3fbc50a350
commit 05a441afb2
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/VM/Region.cpp
View file

@ -57,7 +57,8 @@ NonnullOwnPtr<Region> Region::clone()
// NOTE: Kernel-only regions should never be cloned. // NOTE: Kernel-only regions should never be cloned.
ASSERT(is_user_accessible()); ASSERT(is_user_accessible());
if (m_shared || (is_readable() && !is_writable())) { // FIXME: What should we do for privately mapped InodeVMObjects?
if (m_shared || vmobject().is_inode()) {
ASSERT(!m_stack); ASSERT(!m_stack);
#ifdef MM_DEBUG #ifdef MM_DEBUG
dbgprintf("%s<%u> Region::clone(): sharing %s (V%p)\n", dbgprintf("%s<%u> Region::clone(): sharing %s (V%p)\n",