RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:37:42 +00:00
Code Issues Activity Actions

LibWeb: Don't allocate DOMStringMap in HTMLElement constructor

Browse source 
Allocations go in initialize().
This commit is contained in:
Andreas Kling 2022-09-03 18:49:56 +02:00
parent b30e95eb27
commit 05dcf3b2f8
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/HTMLElement.cpp
View file

@ -30,13 +30,18 @@ namespace Web::HTML {
HTMLElement::HTMLElement(DOM::Document& document, DOM::QualifiedName qualified_name) HTMLElement::HTMLElement(DOM::Document& document, DOM::QualifiedName qualified_name)
: Element(document, move(qualified_name)) : Element(document, move(qualified_name))
, m_dataset(DOMStringMap::create(*this))
{ {
set_prototype(&window().cached_web_prototype("HTMLElement")); set_prototype(&window().cached_web_prototype("HTMLElement"));
} }
HTMLElement::~HTMLElement() = default; HTMLElement::~HTMLElement() = default;
void HTMLElement::initialize(JS::Realm& realm)
{
Base::initialize(realm);
m_dataset = DOMStringMap::create(*this);
}
void HTMLElement::visit_edges(Cell::Visitor& visitor) void HTMLElement::visit_edges(Cell::Visitor& visitor)
{ {
Base::visit_edges(visitor); Base::visit_edges(visitor);

4
Userland/Libraries/LibWeb/HTML/HTMLElement.h
View file

@ -52,6 +52,8 @@ public:
protected: protected:
HTMLElement(DOM::Document&, DOM::QualifiedName); HTMLElement(DOM::Document&, DOM::QualifiedName);
virtual void initialize(JS::Realm&) override;
virtual void parse_attribute(FlyString const& name, String const& value) override; virtual void parse_attribute(FlyString const& name, String const& value) override;
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
@ -69,7 +71,7 @@ private:
}; };
ContentEditableState content_editable_state() const; ContentEditableState content_editable_state() const;
JS::NonnullGCPtr<DOMStringMap> m_dataset; JS::GCPtr<DOMStringMap> m_dataset;
// https://html.spec.whatwg.org/multipage/interaction.html#locked-for-focus // https://html.spec.whatwg.org/multipage/interaction.html#locked-for-focus
bool m_locked_for_focus { false }; bool m_locked_for_focus { false };