mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 11:27:35 +00:00
Userland: Properly define IPC::encode and IPC::decode specializations
In order to avoid the base encode/decode methods from being used (and failing a static assertion), we must be sure to declare/define the custom type implementations as template specializations. After this, LibIPC is no longer sensitive to include order.
This commit is contained in:
parent
b1ea418d14
commit
05f41382bb
25 changed files with 75 additions and 2 deletions
|
@ -38,6 +38,7 @@ SameSite same_site_from_string(StringView same_site_mode)
|
|||
|
||||
}
|
||||
|
||||
template<>
|
||||
bool IPC::encode(Encoder& encoder, Web::Cookie::Cookie const& cookie)
|
||||
{
|
||||
encoder << cookie.name;
|
||||
|
@ -56,6 +57,7 @@ bool IPC::encode(Encoder& encoder, Web::Cookie::Cookie const& cookie)
|
|||
return true;
|
||||
}
|
||||
|
||||
template<>
|
||||
ErrorOr<void> IPC::decode(Decoder& decoder, Web::Cookie::Cookie& cookie)
|
||||
{
|
||||
TRY(decoder.decode(cookie.name));
|
||||
|
|
|
@ -46,7 +46,10 @@ SameSite same_site_from_string(StringView same_site_mode);
|
|||
|
||||
namespace IPC {
|
||||
|
||||
template<>
|
||||
bool encode(Encoder&, Web::Cookie::Cookie const&);
|
||||
|
||||
template<>
|
||||
ErrorOr<void> decode(Decoder&, Web::Cookie::Cookie&);
|
||||
|
||||
}
|
||||
|
|
|
@ -347,6 +347,7 @@ Optional<Core::DateTime> parse_date_time(StringView date_string)
|
|||
|
||||
}
|
||||
|
||||
template<>
|
||||
bool IPC::encode(Encoder& encoder, Web::Cookie::ParsedCookie const& cookie)
|
||||
{
|
||||
encoder << cookie.name;
|
||||
|
@ -362,6 +363,7 @@ bool IPC::encode(Encoder& encoder, Web::Cookie::ParsedCookie const& cookie)
|
|||
return true;
|
||||
}
|
||||
|
||||
template<>
|
||||
ErrorOr<void> IPC::decode(Decoder& decoder, Web::Cookie::ParsedCookie& cookie)
|
||||
{
|
||||
TRY(decoder.decode(cookie.name));
|
||||
|
|
|
@ -32,7 +32,10 @@ Optional<ParsedCookie> parse_cookie(String const& cookie_string);
|
|||
|
||||
namespace IPC {
|
||||
|
||||
template<>
|
||||
bool encode(Encoder&, Web::Cookie::ParsedCookie const&);
|
||||
|
||||
template<>
|
||||
ErrorOr<void> decode(Decoder&, Web::Cookie::ParsedCookie&);
|
||||
|
||||
}
|
||||
|
|
|
@ -27,6 +27,7 @@ Response::Response(Error&& error)
|
|||
|
||||
}
|
||||
|
||||
template<>
|
||||
bool IPC::encode(Encoder& encoder, Web::WebDriver::Response const& response)
|
||||
{
|
||||
response.visit(
|
||||
|
@ -46,6 +47,7 @@ bool IPC::encode(Encoder& encoder, Web::WebDriver::Response const& response)
|
|||
return true;
|
||||
}
|
||||
|
||||
template<>
|
||||
ErrorOr<void> IPC::decode(Decoder& decoder, Web::WebDriver::Response& response)
|
||||
{
|
||||
ResponseType type {};
|
||||
|
|
|
@ -46,7 +46,10 @@ private:
|
|||
|
||||
namespace IPC {
|
||||
|
||||
template<>
|
||||
bool encode(Encoder&, Web::WebDriver::Response const&);
|
||||
|
||||
template<>
|
||||
ErrorOr<void> decode(Decoder&, Web::WebDriver::Response&);
|
||||
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue