RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:47:45 +00:00
Code Issues Activity Actions

Ladybird: Fix JS console crash when history is empty

Browse source 
Do not try to navigate JS console history forward when it is empty. A
crash was occurring because of size_t underflow.
This commit is contained in:
Sebastian Zaha 2023-07-31 23:07:49 +02:00 • committed by Andreas Kling
parent cd0fe4bb48
commit 05fc63932b
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Ladybird/ConsoleWidget.cpp
View file

@ -175,6 +175,8 @@ void ConsoleInputEdit::keyPressEvent(QKeyEvent* event)
{ {
switch (event->key()) { switch (event->key()) {
case Qt::Key_Down: { case Qt::Key_Down: {
if (m_history.is_empty())
break;
auto last_index = m_history.size() - 1; auto last_index = m_history.size() - 1;
if (m_history_index < last_index) { if (m_history_index < last_index) {
m_history_index++; m_history_index++;