RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:27:35 +00:00
Code Issues Activity Actions

LibWeb: Make the Window object "inherit" from EventTarget :^)

Browse source 
Since Web::Bindings::WindowObject inherits from JS::GlobalObject, it
cannot also inherit from Web::Bindings::EventTargetWrapper.

However, that's not actually necessary. Instead, we simply set the
Window object's prototype to the EventTargetPrototype, and add a little
extra branch in the impl_from() function that turns the JS "this" value
into a DOM::EventTarget*.

With this, you can now call window.addEventListener()! Very cool :^)

Fixes #4758.
This commit is contained in:
Andreas Kling 2021-01-18 12:15:02 +01:00
parent fd83918476
commit 0639e77898
13 changed files with 26 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/Window.cpp
View file

@ -169,9 +169,9 @@ bool Window::dispatch_event(NonnullRefPtr<Event> event)
return EventDispatcher::dispatch(*this, event, true);
}
Bindings::EventTargetWrapper* Window::create_wrapper(JS::GlobalObject&)
JS::Object* Window::create_wrapper(JS::GlobalObject& global_object)
{
ASSERT_NOT_REACHED();
return &global_object;
}
}