RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:48:12 +00:00
Code Issues Activity Actions

Shell: Move the first command in a pipeline to the pipeline pgid too

Browse source 
This process is supposed to be the session leader of the pipeline
process group, we can't *not* move it into that group :P
This commit is contained in:
AnotherTest 2020-09-12 23:41:07 +04:30 • committed by Andreas Kling
parent d366e996dd
commit 063fb02ef4
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Shell/Shell.cpp
View file

@ -622,12 +622,14 @@ RefPtr<Job> Shell::run_command(const AST::Command& command)
} }
pid_t pgid = is_first ? child : (command.pipeline ? command.pipeline->pgid : child); pid_t pgid = is_first ? child : (command.pipeline ? command.pipeline->pgid : child);
if (!m_is_subshell && command.should_wait) { if ((!m_is_subshell && command.should_wait) || command.pipeline) {
if (setpgid(child, pgid) < 0) if (setpgid(child, pgid) < 0)
perror("setpgid"); perror("setpgid");
tcsetpgrp(STDOUT_FILENO, pgid); if (!m_is_subshell) {
tcsetpgrp(STDIN_FILENO, pgid); tcsetpgrp(STDOUT_FILENO, pgid);
tcsetpgrp(STDIN_FILENO, pgid);
}
} }
while (write(sync_pipe[1], "x", 1) < 0) { while (write(sync_pipe[1], "x", 1) < 0) {